Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torint: delete a compile-time check that uses SIZEOF_UNSIGNED_INT #871

Closed
wants to merge 1 commit into from

Conversation

Labels
None yet
Projects
None yet
2 participants
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 30, 2019

We do not define SIZEOF_UNSIGNED_INT, so this comparison is always false.
Compilers that support -Wundef issue a diagnostic warning for it.

Fixes bug 29958; bugfix on 29537; not in any released version of Tor.

We do not define SIZEOF_UNSIGNED_INT, so this comparison is always false.
Compilers that support -Wundef issue a diagnostic warning for it.

Fixes bug 29958; bugfix on 29537; not in any released version of Tor.
@coveralls
Copy link

@coveralls coveralls commented Mar 30, 2019

Pull Request Test Coverage Report for Build 4474

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 62.261%

Files with Coverage Reduction New Missed Lines %
src/core/or/circuitpadding.c 3 92.07%
Totals Coverage Status
Change from base Build 4473: 0.01%
Covered Lines: 46182
Relevant Lines: 74175

💛 - Coveralls

@teor2345 teor2345 closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment