Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug29960 #874

Closed
wants to merge 6 commits into from
Closed

Bug29960 #874

wants to merge 6 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teor2345 @coveralls
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 30, 2019

No description provided.

teor2345 added 6 commits Mar 30, 2019
@teor2345
bwauth: Actually include the bandwidth-file-digest in authority votes
a76e833 
Fixes bug 29959; bugfix on 0.4.0.2-alpha.
@teor2345
crypto_format: Stop ignoring errors in digest256_to_base64()
2f6c98c 
Part of 29960.
@teor2345
Check for errors when calling digest256_to_base64()
24374ac 
Part of 29960.
@teor2345
Check for errors when calling ed25519_public_to_base64()
4e3e070 
ed25519_public_to_base64() calls digest256_to_base64().

Closes 29960.
@teor2345
Changes file for 29960
b6f4726
@teor2345
practracker: Accept the extra error checking in 29960
7b02811
@coveralls
Copy link

@coveralls coveralls commented Mar 30, 2019

Pull Request Test Coverage Report for Build 4478

  • 26 of 55 (47.27%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 62.255%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/routerlist.c 3 5 60.0%
src/feature/dirauth/keypin.c 3 6 50.0%
src/feature/dirclient/dirclient.c 0 4 0.0%
src/feature/hs/hs_cache.c 4 8 50.0%
src/feature/hs/hs_intropoint.c 0 4 0.0%
src/feature/nodelist/fmt_routerstatus.c 0 4 0.0%
src/core/or/connection_or.c 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.33%
src/feature/dirclient/dirclient.c 1 18.34%
Totals Coverage Status
Change from base Build 4473: 0.006%
Covered Lines: 46198
Relevant Lines: 74208
💛 - Coveralls

@teor2345 teor2345 closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment