Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug29036 029 #877

Merged
merged 5 commits into from Apr 5, 2019
Merged

Bug29036 029 #877

merged 5 commits into from Apr 5, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @torproject-pusher @ahf
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 1, 2019

No description provided.

ahf and others added 3 commits Mar 20, 2019
@ahf
Run `make reset-gcov` after the script target in Travis CI is done.
0267c45 
This should ensure that GCDA files are never entering the cache of
Travis CI.

See: https://bugs.torproject.org/29036
@ahf
Handle errors from coveralls more gracefully.
fbb1c7a 
Since we have moved coveralls to the script target the entire build will
now fail if coveralls fail. We handle it more gracefully by echo'ing the
failure instead of doing a hard-failure.

See: https://bugs.torproject.org/29036
@teor2345
changes: Use the first Tor version with CI coverage for the 29036 cha…
eb0bd18 
…nges file

Otherwise, "make check-changes" will complain when we backport the change.
@coveralls
Copy link

@coveralls coveralls commented Apr 1, 2019 •
edited

Pull Request Test Coverage Report for Build 4583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 50.142%
Files with Coverage Reduction New Missed Lines %
src/or/dirvote.c 1 68.55%
src/ext/trunnel/trunnel.c 1 34.48%
src/or/shared_random.c 1 86.08%
src/or/circuitstats.c 2 73.4%
src/or/routerparse.c 6 73.1%
Totals Coverage Status
Change from base Build 4288: -0.02%
Covered Lines: 29508
Relevant Lines: 58849
💛 - Coveralls

@teor2345
Makefile: delete all the gcov-related files in reset-gcov
57e9fe2 
And fix a comment.

See:
https://gcc.gnu.org/onlinedocs/gcc/Gcov-Data-Files.html#Gcov-Data-Files
@teor2345
Makefile: actually, don't delete the gcno files
f0cd8f8 
We need to keep the gcno files, because they are created at compile time.
@torproject-pusher torproject-pusher merged commit f0cd8f8 into torproject:maint-0.2.9 Apr 5, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment