Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug29036 29962 040 #881

Closed
wants to merge 14 commits into from
Closed

Bug29036 29962 040 #881

wants to merge 14 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @ahf @rl1987
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 1, 2019

No description provided.

ahf and others added 10 commits Mar 20, 2019
@ahf
Run `make reset-gcov` after the script target in Travis CI is done.
0267c45 
This should ensure that GCDA files are never entering the cache of
Travis CI.

See: https://bugs.torproject.org/29036
@ahf
Handle errors from coveralls more gracefully.
fbb1c7a 
Since we have moved coveralls to the script target the entire build will
now fail if coveralls fail. We handle it more gracefully by echo'ing the
failure instead of doing a hard-failure.

See: https://bugs.torproject.org/29036
@teor2345
changes: Use the first Tor version with CI coverage for the 29036 cha…
eb0bd18 
…nges file

Otherwise, "make check-changes" will complain when we backport the change.
@teor2345
Makefile: delete all the gcov-related files in reset-gcov
57e9fe2 
And fix a comment.

See:
https://gcc.gnu.org/onlinedocs/gcc/Gcov-Data-Files.html#Gcov-Data-Files
@teor2345
Merge branch 'bug29036-029' into bug29036-29962-034
ac28e56
@rl1987 @teor2345
Cleanup cargo registry before each Rust-enabled build
0c6cfd9 
Also, refrain from caching target/.

See: https://levans.fr/rust_travis_cache.html
@rl1987 @teor2345
Add changes file
124990a
@teor2345
Travis: merge before_cache from 29036 and 29962
33be8d8 
And add some useful comments
@teor2345
Merge branch 'bug29036-29962-034' into bug29036-29962-035
7014e57 
Merge the moved coverage line from 29036 with the stem changes in
maint-0.3.5.
@teor2345
Merge branch 'bug29036-29962-035' into bug29036-29962-040
f4c3b90
@teor2345 teor2345 closed this Apr 1, 2019
@teor2345 teor2345 reopened this Apr 1, 2019
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Apr 1, 2019

This pull request had the wrong merge head due to a GitHub UI bug, see #880 for details.

@coveralls
Copy link

@coveralls coveralls commented Apr 1, 2019 •
edited

Pull Request Test Coverage Report for Build 4584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 552 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.001%) to 61.727%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.45%
src/feature/hs/hs_common.c 1 83.28%
src/core/mainloop/connection.h 3 50.0%
src/feature/dircache/dircache.c 48 70.38%
src/core/mainloop/connection.c 131 25.62%
src/feature/dirauth/dirvote.c 368 65.18%
Totals Coverage Status
Change from base Build 4444: -0.001%
Covered Lines: 45343
Relevant Lines: 73457
💛 - Coveralls

teor2345 added 4 commits Apr 5, 2019
@teor2345
Makefile: actually, don't delete the gcno files
f0cd8f8 
We need to keep the gcno files, because they are created at compile time.
@teor2345
Merge branch 'bug29036-029' into bug29036-29962-034
a514e02
@teor2345
Merge branch 'bug29036-29962-034' into bug29036-29962-035
db71bce
@teor2345
Merge branch 'bug29036-29962-035' into bug29036-29962-040
bbebe64
@teor2345 teor2345 closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment