Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29979: Removed the use of expect from CodingStandardsRust #883

Closed
wants to merge 2 commits into from

Conversation

Labels
None yet
Projects
None yet
4 participants
@elichai
Copy link
Contributor

@elichai elichai commented Apr 1, 2019

Hi,
After watching your talk (https://www.youtube.com/watch?v=WI4ApeHH9QE) I came to read the documentation here,
and you're telling to use expect() instead of unwrap() but expect also makes the whole program panic and unwind.
so neither expect should be used unless justified.

@coveralls
Copy link

@coveralls coveralls commented Apr 1, 2019

Pull Request Test Coverage Report for Build 4514

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 62.26%

Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.33%
src/core/or/circuitpadding.c 3 92.07%
Totals Coverage Status
Change from base Build 4473: 0.01%
Covered Lines: 46181
Relevant Lines: 74175

💛 - Coveralls

doc/HACKING/CodingStandardsRust.md Outdated Show resolved Hide resolved
Copy link
Contributor

@teor2345 teor2345 left a comment

Thanks for the pull request!
There are just a few typos that need fixing.

We use trac as our task tracker, this change is being tracked in:
https://trac.torproject.org/projects/tor/ticket/29979

@teor2345 teor2345 changed the title Removed the use of expect from CodingStandardsRust 29979: Removed the use of expect from CodingStandardsRust Apr 1, 2019
Co-Authored-By: elichai <elichai.turkel@gmail.com>
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 3, 2019

Thanks! Someone else will squash and merge in the next few days.

@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 3, 2019

Squashed and merged!

@nmathewson nmathewson closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment