#29060: Stop requiring bash in test-network.sh. Make it POSIX compliant #884
Conversation
Pull Request Test Coverage Report for Build 4516
|
teor2345
reviewed
Apr 3, 2019
| shift | ||
| done | ||
| CHUTNEY_PATH=$(echo "$@" | awk -F '--chutney-path ' '{sub(" .*","",$2); print $2}') | ||
| TOR_DIR=$(echo "$@" | awk -F '--tor-dir ' '{sub(" .*","",$2); print $2}') |
How do these awk commands handle quoted strings with spaces?
They return the first thing that comes after e.g. --chutney-path until the whitespace character, so it this not handle paths with spaces in them properly. We're not losing any functionality here, as the script didn't know how to handle them previously either - further in the script we're suggesting the user to set CHUTNEY_PATH and TOR_DIR environment variables as workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://trac.torproject.org/projects/tor/ticket/29060
The text was updated successfully, but these errors were encountered: