Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug30021 035 #904

Merged
merged 2 commits into from Apr 5, 2019
Merged

Bug30021 035 #904

merged 2 commits into from Apr 5, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 4, 2019

No description provided.

nmathewson added 2 commits Apr 4, 2019
@nmathewson
Do not cache bogus results from classifying client ciphers
1710f4b 
When classifying a client's selection of TLS ciphers, if the client
ciphers are not yet available, do not cache the result. Previously,
we had cached the unavailability of the cipher list and never looked
again, which in turn led us to assume that the client only supported
the ancient V1 link protocol.  This, in turn, was causing Stem
integration tests to stall in some cases.  Fixes bug 30021; bugfix
on 0.2.4.8-alpha.
@nmathewson
Merge branch 'bug30021_029' into bug30021_035
db1c1db
@coveralls
Copy link

@coveralls coveralls commented Apr 4, 2019

Pull Request Test Coverage Report for Build 4568

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 62.232%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.33%
src/core/or/circuitpadding.c 11 91.02%
Totals Coverage Status
Change from base Build 4540: -0.01%
Covered Lines: 46159
Relevant Lines: 74173
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit db1c1db into torproject:master Apr 5, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment