Detect and suppress an additional gmtime() warning in test_util.c #915

nmathewson · 2019-04-08T21:03:36Z

Fixes bug 29922; bugfix on 0.2.9.3-alpha when we tried to capture
all these warnings. No need to backport any farther than 0.3.5,
though -- these warnings don't cause test failures before then.

This one was tricky to find because apparently it only happened on
some windows builds.

Fixes bug 29922; bugfix on 0.2.9.3-alpha when we tried to capture all these warnings. No need to backport any farther than 0.3.5, though -- these warnings don't cause test failures before then. This one was tricky to find because apparently it only happened on _some_ windows builds.

coveralls · 2019-04-08T21:27:55Z

Pull Request Test Coverage Report for Build 4653

0 of 0 changed or added relevant lines in 0 files are covered.
13 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 60.303%

Files with Coverage Reduction	New Missed Lines	%
src/feature/hs/hs_common.c	1	83.28%
src/feature/dirauth/shared_random.c	3	85.64%
src/feature/dirauth/dirvote.c	9	64.79%

Totals
Change from base Build 4618:	-0.02%
Covered Lines:	42857
Relevant Lines:	71070

💛 - Coveralls

Actually I believe this should be an EINVAL.

9f3f999

torproject-pusher merged commit 9f3f999 into torproject:maint-0.3.5 Apr 10, 2019
2 checks passed

torproject / tor Public

Detect and suppress an additional gmtime() warning in test_util.c #915

Detect and suppress an additional gmtime() warning in test_util.c #915

nmathewson commented Apr 8, 2019

coveralls commented Apr 8, 2019 •

edited

torproject / tor Public

Detect and suppress an additional gmtime() warning in test_util.c #915

Detect and suppress an additional gmtime() warning in test_util.c #915

Conversation

nmathewson commented Apr 8, 2019

coveralls commented Apr 8, 2019 • edited

Pull Request Test Coverage Report for Build 4653

💛 - Coveralls

coveralls commented Apr 8, 2019 •

edited