Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket30149 #938

Merged
merged 5 commits into from Apr 18, 2019
Merged

Ticket30149 #938

merged 5 commits into from Apr 18, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 11, 2019

No description provided.

nmathewson added 5 commits Apr 11, 2019
@nmathewson
Add an assertion to pathbias_get_scale_ratio()
55690d0 
This should please coverity, and fix CID 1415723.  It didn't understand
that networkstatus_get_param() always returns a value between its
minimum and maximum values.
@nmathewson
Add an assertion to compute_weighted_bandwidths()
96e3109 
This should please coverity, and fix CID 1415722.  It didn't
understand that networkstatus_get_param() always returns a value
between its minimum and maximum values.
@nmathewson
Add an assertion to num_ntors_per_tap().
66b07e7 
This should please coverity, and fix CID 1415721.  It didn't
understand that networkstatus_get_param() always returns a value
between its minimum and maximum values.
@nmathewson
Remove an extraneous _ from __COVERITY__
48a5746 
We had a typo in this check, so that coverity wasn't taking the
right path.

Bug not in any released Tor.
@nmathewson
Changes file and practracker updates for 30149.
7332346
@coveralls
Copy link

@coveralls coveralls commented Apr 11, 2019

Pull Request Test Coverage Report for Build 4701

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 62.253%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/client/circpathbias.c 0 1 0.0%
Totals Coverage Status
Change from base Build 4696: 0.006%
Covered Lines: 46187
Relevant Lines: 74193
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 7332346 into torproject:master Apr 18, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment