Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust panic1 034 #946

Merged
merged 2 commits into from Apr 19, 2019
Merged

Rust panic1 034 #946

merged 2 commits into from Apr 19, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 15, 2019

No description provided.

cypherpunks and others added 2 commits Aug 18, 2018
rust: abort on panic in all profiles
fecd583 
Until rust-lang/rust#52652 is fixed,
unwinding on panic is potentially unsound in a mixed C/Rust codebase.

The codebase is supposed to be panic-free already, but just to be safe.

This started mattering at commit d1820c1.

Fixes #27199; bugfix on tor-0.3.3.1-alpha.
@teor2345
Merge branch 'rust-panic1' into rust-panic1-034
5ab5c8e
@coveralls
Copy link

@coveralls coveralls commented Apr 15, 2019

Pull Request Test Coverage Report for Build 4725

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 59.941%
Files with Coverage Reduction New Missed Lines %
src/or/dirauth/shared_random.c 1 86.39%
src/or/dirauth/dirvote.c 1 65.53%
src/or/routerparse.c 6 76.57%
Totals Coverage Status
Change from base Build 4617: -0.01%
Covered Lines: 41858
Relevant Lines: 69832
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 5ab5c8e into torproject:maint-0.3.4 Apr 19, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment