Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn about compatible OpenSSL upgrades #951

Merged
merged 1 commit into from Aug 12, 2019

Conversation

Labels
None yet
Projects
None yet
4 participants
@bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Apr 15, 2019

Do not warn about compatible OpenSSL upgrades.

When releasing OpenSSL patch-level maintenance updates,
we do not want to rebuild binaries using it.
And since they guarantee ABI stability, we do not have to.

Without this patch, warning messages were produced
that confused users:
https://bugzilla.opensuse.org/show_bug.cgi?id=1129411

@coveralls
Copy link

@coveralls coveralls commented Apr 15, 2019

Pull Request Test Coverage Report for Build 5785

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 934 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.305%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/crypt_ops/crypto_openssl_mgt.c 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_service.c 4 73.72%
src/lib/container/buffers.c 6 91.03%
src/app/config/config.c 14 72.15%
src/feature/relay/router.c 31 34.88%
src/feature/dirparse/routerparse.c 34 93.04%
src/feature/nodelist/routerlist.c 46 37.57%
src/lib/net/address.c 55 91.1%
src/core/or/channeltls.c 72 43.37%
src/core/mainloop/connection.c 232 25.39%
src/core/or/circuituse.c 440 29.4%
Totals Coverage Status
Change from base Build 4665: -0.02%
Covered Lines: 42872
Relevant Lines: 71092

💛 - Coveralls

@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 15, 2019

Thanks for this pull request!

We do our task tracking using our own Trac instance, I've opened a ticket here:
https://trac.torproject.org/projects/tor/ticket/30190#comment:2

I think we've had issues in the past where OpenSSL has promised version compatibility, but failed to deliver. I've assigned the review to one of our developers who should be able to provide more details.

We try to do reviews within a week.

@bmwiedemann bmwiedemann changed the base branch from master to maint-0.3.5 Apr 16, 2019
@bmwiedemann bmwiedemann force-pushed the boo1129411 branch 3 times, most recently from a71042c to f7dd27e Apr 16, 2019
When releasing OpenSSL patch-level maintenance updates,
we do not want to rebuild binaries using it.
And since they guarantee ABI stability, we do not have to.

Without this patch, warning messages were produced
that confused users:
https://bugzilla.opensuse.org/show_bug.cgi?id=1129411

Fixes bug 30190; bugfix on 0.2.4.2-alpha commit 7607ad2

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@teor2345 teor2345 reopened this Aug 11, 2019
@torproject-pusher torproject-pusher merged commit 8c4e684 into torproject:maint-0.3.5 Aug 12, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment