Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug30189 041 #953

Merged
merged 2 commits into from Apr 25, 2019
Merged

Bug30189 041 #953

merged 2 commits into from Apr 25, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 15, 2019

No description provided.

nmathewson added 2 commits Apr 15, 2019
@nmathewson
Use a tor_abort_() wrapper in our util_bug.h macros
802ac8a 
Previously, our use of abort() would break anywhere that we didn't
include stdlib.h.  This was especially troublesome in case where
tor_assert_nonfatal() was used with ALL_BUGS_ARE_FATAL, since that
one seldom gets tested.

As an alternative, we could have just made this header include
stdlib.h.  But that seems bloaty.

Fixes bug 30189; bugfix on 0.3.4.1-alpha.
@nmathewson
Merge branch 'bug30189_035' into bug30189_041
358df18
@coveralls
Copy link

@coveralls coveralls commented Apr 15, 2019

Pull Request Test Coverage Report for Build 4738

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.262%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/log/util_bug.c 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 4732: -0.02%
Covered Lines: 46189
Relevant Lines: 74185
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 358df18 into torproject:master Apr 25, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment