Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket30176 #955

Merged
merged 3 commits into from Apr 24, 2019
Merged

Ticket30176 #955

merged 3 commits into from Apr 24, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @torproject-pusher @stoeckmann
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 15, 2019

No description provided.

stoeckmann and others added 3 commits Apr 15, 2019
@stoeckmann @nmathewson
Add test to verify that unused pointers are NULL.
5a0c857 
The smartlist code takes great care to set all unused pointers inside
the smartlist memory to NULL. Check if this is also the case after
modifying the smartlist multiple times.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
@stoeckmann @nmathewson
Clear memory in smartlist_remove_keeporder.
670d0f9 
The smartlist functions take great care to reset unused pointers inside
the smartlist memory to NULL.

The function smartlist_remove_keeporder does not clear memory in such
way when elements have been removed. Therefore call memset after the
for-loop that removes elements. If no element is removed, it is
effectively a no-op.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
@nmathewson
Document check for 30176, since it's a bit subtle.
82a3161
@coveralls
Copy link

@coveralls coveralls commented Apr 15, 2019

Pull Request Test Coverage Report for Build 4740

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.262%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitpadding.c 3 92.07%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 4732: -0.02%
Covered Lines: 46189
Relevant Lines: 74185
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 82a3161 into torproject:master Apr 24, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment