Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug29034 0.3.5 #969

wants to merge 2 commits into
base: maint-0.3.5


Copy link

commented Apr 19, 2019

No description provided.


This comment has been minimized.

Copy link

commented Apr 19, 2019

Pull Request Test Coverage Report for Build 4796

  • 6 of 11 (54.55%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/hs/hs_circuit.c 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuituse.c 1 29.51%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.79%
Totals Coverage Status
Change from base Build 4790: -0.02%
Covered Lines: 42864
Relevant Lines: 71083

💛 - Coveralls

ocirc->hs_ident = NULL;

This comment has been minimized.

Copy link

dgoulet-tor May 6, 2019


My two cents here. I would much prefer we go with a hs_circ_repurpose() kind of function instead which would do this and call hs_circ_cleanup().

One of the reason I say that also is because crypto_pk_free() and rend_data_free() is v2 and hs_circ_cleanup() is v3 only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.