Join GitHub today
[Tor Trac #22029]: Allow ed25519 keys to be banned in the approved-routers file (Revision 3) #970
Pull Request Test Coverage Report for Build 5389
teor2345 left a comment
There are two major bugs in this code:
dirserv_get_status_impl() is also called from dirserv_would_reject_router().
A call to dirserv_get_status_impl() is in the wrong place.
Please add some tests for dirserv_router_get_status() and dirserv_would_reject_router() that fail on the current code, but succeed when you fix these bugs.
Does this change fail practracker?