Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower log level of unlink() errors in networkstatus_set_current_conse… #978

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Labels
None yet
Projects
None yet
3 participants
@ahf
Copy link
Member

@ahf ahf commented Apr 25, 2019

…nsus().

In this patch we lower the log level of the failures for the three calls
to unlink() in networkstatus_set_current_consensus(). These errors might
trigger on Windows because the memory mapped consensus file keeps the
file in open state even after we have close()'d it. Windows will then
error on the unlink() call with a "Permission denied" error.

The consequences of ignoring these errors is that we leave an unused
file around on the file-system, which is an easier way to fix this
problem right now than refactoring networkstatus_set_current_consensus().

See: https://bugs.torproject.org/29930

…nsus().

In this patch we lower the log level of the failures for the three calls
to unlink() in networkstatus_set_current_consensus(). These errors might
trigger on Windows because the memory mapped consensus file keeps the
file in open state even after we have close()'d it. Windows will then
error on the unlink() call with a "Permission denied" error.

The consequences of ignoring these errors is that we leave an unused
file around on the file-system, which is an easier way to fix this
problem right now than refactoring networkstatus_set_current_consensus().

See: https://bugs.torproject.org/29930
@coveralls
Copy link

@coveralls coveralls commented Apr 25, 2019

Pull Request Test Coverage Report for Build 4837

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 61.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/networkstatus.c 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitpadding.c 2 93.33%
Totals Coverage Status
Change from base Build 4792: -0.003%
Covered Lines: 45360
Relevant Lines: 73489

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 0429072 into torproject:maint-0.4.0 Apr 30, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment