Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug29209 v2 #982

Closed
wants to merge 18 commits into from
Closed

Bug29209 v2 #982

wants to merge 18 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asn-d6 @coveralls @torproject-pusher
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Apr 26, 2019

No description provided.

asn-d6 added 17 commits Apr 10, 2019
@asn-d6
Hiding crypt_path_t: Introduce opaque crypt_path_private_t .
dbcb4a8 
This will be our base for incrementally hiding crypt_path_t.
@asn-d6
Hiding crypt_path_t: Move assert functions in crypt_path.c.
9aaf98e 
This commit only moves code, and makes one function public.
@asn-d6
Hiding crypt_path_t: Move init functions to crypt_path.c.
688a642 
This commit only moves code.
@asn-d6
Hiding crypt_path_t: Start with crypt_path.crypto .
42ee8a4 
Create some functions to eventually be able to hide crypt_path_t.crypto.
@asn-d6
Hiding crypt_path_t: Move some more init funcs in crypt_path.c.
04641bd 
Everything is moved, but the argument of the function is edited to access
->private->crypto.
@asn-d6
Hiding crypt_path_t: Move the free func in crypt_path.c.
231d2a3 
Again everything is moved, apart from a free line using ->private.
@asn-d6
Hiding crypt_path_t: Fixup broken unittests.
22cf529
@asn-d6
Hiding crypt_path_t: Create a constructor for crypt_path_t.
ab8b809 
We are using an opaque pointer so the structure needs to be allocated on the
heap. This means we now need a constructor for crypt_path_t.

Also modify all places initializing a crypt_path_t to use the constructor.
@asn-d6
Hiding crypt_path_t: Ensure that ->private is initialized.
7497c91 
Now that we are using a constructor we should be more careful that we are
always using the constructor to initialize crypt_path_t, so make sure that
->private is initialized.
@asn-d6
Hiding crypt_path_t: Trivial changes to satisfy check-local.
ebec3cf
@asn-d6
Hiding crypt_path_t: Rename some functions to fit the crypt_path API.
e2595e5 
Some of these functions are now public and cpath-specific so their name should
signify the fact they are part of the cpath module:

assert_cpath_layer_ok -> cpath_assert_layer_ok
assert_cpath_ok -> cpath_assert_ok
onion_append_hop -> cpath_append_hop
circuit_init_cpath_crypto -> cpath_init_circuit_crypto
circuit_free_cpath_node -> cpath_free
onion_append_to_cpath -> cpath_extend_linked_list
@asn-d6
Hiding crypt_path_t: Move some more crypt_path-specific functions.
f29361b 
- Move test-only cpath_get_n_hops() to crypt_path.c.
- Move onion_next_hop_in_cpath() and rename to cpath_get_next_non_open_hop().

The latter function was directly accessing cpath->state, and it's a first step
at hiding ->state.
@asn-d6
Hiding crypt_path_t: Some TODO notes for future directions.
4d518c1
@asn-d6
Revert "Hiding crypt_path_t: Create a constructor for crypt_path_t."
6a4b843 
This reverts commit ab8b809.
@asn-d6
Revert "Hiding crypt_path_t: Ensure that ->private is initialized."
0cf589a 
This reverts commit 7497c91.
@asn-d6
Hiding crypt_path_t: Hiding 'crypto' using a macro.
120d8b8
@asn-d6
Hiding crypt_path_t: Change code to use the privatization macro.
09856de
@coveralls
Copy link

@coveralls coveralls commented Apr 26, 2019 •
edited

Pull Request Test Coverage Report for Build 4893

  • 65 of 94 (69.15%) changed or added relevant lines in 7 files are covered.
  • 17 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.304%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuitlist.c 3 5 60.0%
src/feature/rend/rendservice.c 0 2 0.0%
src/core/or/circuitbuild.c 1 6 16.67%
src/core/or/crypt_path.c 53 73 72.6%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.33%
src/feature/hs/hs_common.c 1 83.75%
src/core/or/circuitpadding.c 3 92.07%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 4851: 0.02%
Covered Lines: 46253
Relevant Lines: 74238
💛 - Coveralls

@asn-d6
fixup! Hiding crypt_path_t: Hiding 'crypto' using a macro.
81554a7
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment