Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket30307 30308 #983

Merged
merged 3 commits into from Apr 30, 2019
Merged

Ticket30307 30308 #983

merged 3 commits into from Apr 30, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 26, 2019

No description provided.

nmathewson added 3 commits Apr 26, 2019
@nmathewson
Make nodelist_get_list() return a const pointer.
1d44ac9
@nmathewson
Use a linear algorithm to subtract two nodelists.
650b94e 
The nodelist_idx for each node_t serves as a unique identifier for
the node, so we can use a bitarray to hold all the excluded
nodes, and then remove them from the smartlist.

Previously use used smartlist_subtract(sl, excluded), which is
O(len(sl)*len(excluded)).

We can use this function in other places too, but this is the one
that showed up on the profiles of 30291.

Closes ticket 30307.
@nmathewson
Use fast check for missing id in node_is_a_configured_bridge()
806539b 
Fixes bug 30308; bugfix on 0.3.5.1-alpha.
@coveralls
Copy link

@coveralls coveralls commented Apr 26, 2019

Pull Request Test Coverage Report for Build 4860

  • 28 of 33 (84.85%) changed or added relevant lines in 5 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 62.272%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/node_select.c 23 28 82.14%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 4851: -0.01%
Covered Lines: 46236
Relevant Lines: 74249
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 806539b into torproject:master Apr 30, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment