Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket30309 #994

Merged
merged 3 commits into from May 7, 2019
Merged

Ticket30309 #994

merged 3 commits into from May 7, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Apr 30, 2019

No description provided.

nmathewson added 3 commits Apr 30, 2019
@nmathewson
Rename tor_mem_is_zero to fast_mem_is_zero()
309467c 
For memeq and friends, "tor_" indicates constant-time and "fast_"
indicates optimized.  I'm fine with leaving the constant-time
"safe_mem_is_zero" with its current name, but the "tor_" prefix on
the current optimized version is misleading.

Also, make the tor_digest*_is_zero() uniformly constant-time, and
add a fast_digest*_is_zero() version to use as needed.

A later commit in this branch will fix all the users of
tor_mem_is_zero().

Closes ticket 30309.
@nmathewson
Use safe_mem_is_zero in a few more places.
0034f10 
I don't believe any of these represent a real timing vulnerability
(remote timing against memcmp() on a modern CPU is not easy), but
these are the ones where I believe we should be more careful.
@nmathewson
Replace all remaining tor_mem_is_zero() with fast_mem_is_zero()
295feeb
@coveralls
Copy link

@coveralls coveralls commented Apr 30, 2019

Pull Request Test Coverage Report for Build 4908

  • 45 of 50 (90.0%) changed or added relevant lines in 27 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.364%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/mainloop/connection.c 0 1 0.0%
src/core/or/channeltls.c 0 1 0.0%
src/core/or/circuitbuild.c 0 1 0.0%
src/feature/relay/router.c 1 3 33.33%
Totals Coverage Status
Change from base Build 4905: 0.0%
Covered Lines: 46310
Relevant Lines: 74258
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 295feeb into torproject:master May 7, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment