Bug28693+30173+29203 rebased #997
Closed
Conversation
Disable padding via limit check and machine condition. Limits cause us to stop sending padding. Machine conditions cause the machines to be shut down, and not restarted.
Gotta limit to the limit when the limit is reached.
Test fixes including memory leak from test allocations.
…arams Correct and clarify a comment for the reduced_padding_ok flag.
Relocate disable check to its own function.
Update test for new function.
Pull Request Test Coverage Report for Build 4918
|
asn-d6
reviewed
May 2, 2019
src/core/or/circuitpadding.c
Outdated
| * Return true if padding is allowed by torrc and consensus. | ||
| */ | ||
| STATIC bool | ||
| circpad_is_padding_allowed(void) |
No need to have circpad as a function name prefix since it's a private function to this file.
a151032 does this (and fixes the CI error)
asn-d6
reviewed
May 2, 2019
| if (circpad_padding_disabled || !get_options()->CircuitPadding) { | ||
| return 0; | ||
| } | ||
|
|
We can also pull in
/* Don't schedule padding if we are currently in dormant mode. */
if (!is_participating_on_network()) {
log_info(LD_CIRC, "Not scheduling padding because we are dormant.");
return CIRCPAD_STATE_UNCHANGED;
}
from circpad_machine_schedule_padding in this function.
I would like to keep this separate as it requires its own log line and is a different mechanism that causes it to happen.
Rename disable function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: