Bug4631 #109
Closed
Bug4631 #109
Conversation
Spec change for ticket #4631. Signed-off-by: David Goulet <dgoulet@torproject.org>
Be more specific: clearly distinguish between uploaded and downloaded votes. Add the Tor version that introduces this behaviour. Spec for ticket 4631.
nmathewson
reviewed
Feb 18, 2020
dir-spec.txt
Outdated
| authority has the same set of votes. | ||
| votes they don't have. | ||
|
|
||
| Authorities may also reject any votes that other authorities try to upload |
should "may" be "MAY"? Should it be "SHOULD"?
Changed to SHOULD in b4020ce.
nmathewson
reviewed
Feb 18, 2020
dir-spec.txt
Outdated
|
|
||
| Authorities may also reject any votes that other authorities try to upload | ||
| after this time. | ||
| First appeared: 0.4.4.1-alpha. |
This doesn't "appear" per se-- it isn't a new element in a document. Also, it's not obvious whether "First appeared" applies to the preceding paragraph, or two the two proceding ones. How about instead we say "(0.4.4.1-alpha was the first version to reject votes in this way)" or something?
Fixed in b4020ce.
|
squashed and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: