Code Pull requests 490 Actions Security 0 Insights [Tor Trac #28279]: control: Add a key to GETINFO to fetch the circuit onion handshake rephist values #117
Conversation
… to control-spec.txt
dgoulet-tor
reviewed
Jun 25, 2020
control-spec.txt
Outdated
| "rephist/tap/onion_handshakes_requested" | ||
| "rephist/tap/onion_handshakes_assigned" | ||
| The TAP circuit onion handshake rephist values which are requested or | ||
| assigned. (Introduced in 0.4.4.1-alpha) |
So, nitpick here. rephist is really an internal name of tor.git (and not a very good one if you ask me) but regardless, I think we should expose something more meaningful to the users such as maybe:
stats/circuit/ntor/...
stats/circuit/tap/...
Will ask more people in the net team.
…uested} to control-spec.txt
…uested} to control-spec.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ticket: https://trac.torproject.org/projects/tor/ticket/28279
The text was updated successfully, but these errors were encountered: