Ticket29754 #68
Ticket29754 #68
Conversation
in the header. Part of #29754.
of header and lines generated by sbws. Closes #29754
Also fix some typos.
The final KeyValue isn't followed by SP. The spaces are added between KeyValues when the RelayLine is formatted.
Part of 29754.
Part of 29754.
in the Bandwidth Lines, so that Tor directory authorities do not vote on relays that were not successfully measured, but they are reported in the Bandwidth File. Closes #29813.
When there are not enough eligible relays, put all the relays in the file for diagnostic purposes. But mark them so that Tor ignores them. Specification for 29853.
Here are some initial comments, i might review more if you don't do it in the meanwhile.
Edit: add comments word
bandwidth-file-spec.txt
Outdated
| way they would vote for a relay that is not present in the file. | ||
|
|
||
| This MAY be the case when this relay was not successfully measured but | ||
| the is included in the Bandwidth File, to diagnose why they were not |
| the is included in the Bandwidth File, to diagnose why they were not | |
| it is included in the Bandwidth File, to diagnose why they were not |
Changed in teor2345#1
bandwidth-file-spec.txt
Outdated
| ignore this KeyValue, generator implementations MUST set "bw=1" | ||
| for a relay when Tor directory authorities SHOULD ignore its relay | ||
| line. Using the minimum bw value allows authorities that do not | ||
| understand "vote=0" or "unmeasured=1" to produce sensible votes |
sensible might be a bit abstract?
I'll say "reasonable votes for unmeasured relays".
I rewrote this part in c8cf8db.
bandwidth-file-spec.txt
Outdated
|
|
||
| This KeyValue was added in version 1.4.0 of this specification. | ||
|
|
||
| "real_bw=" Int |
Hmm, we're not calculating the bandwidth for the relays excluded (https://github.com/torproject/sbws/blob/6070d36022dc2130518dd0c68332166b2bf76c73/sbws/lib/v3bwfile.py#L618), though the case here is different.
Since Tor is not going to use it for now, do we really want to include this in this version?.
See my response in:
https://trac.torproject.org/projects/tor/ticket/29853#comment:7
I want to remove real_bw, and use the measured/filtered/scaled bandwidth for relays exluded by under_min_report.
I rewrote this part in c8cf8db.
header KeyValue.
…ons, and headings
|
Squashed in #71. |
No description provided.
The text was updated successfully, but these errors were encountered: