Fix for [TORQUE-1069] and [TORQUE-1053] #152

Merged
merged 1 commit into from Apr 12, 2013

Conversation

Projects
None yet
3 participants
Owner

goldmann commented Apr 10, 2013

[TORQUE-1069] Make it possible to create queues and topic at runtime in the way they are created currently at boot time
[TORQUE-1053] Use QueueInstaller to create queues using TorqueBox::Messaging::Queue.start method

https://issues.jboss.org/browse/TORQUE-1069
https://issues.jboss.org/browse/TORQUE-1053

This commit fixes both issues. The newly introduced Destinationizer
service is now responsible for creating destinations (queues and topic)
across TorqueBox. It does not talk directly to the HornetQ server and it
utilizes the QueueInstaller (or TopicInstaller) classes from polyglot.

The change itself results in a small overhead when creating the queues
(two MSC services are deployed) but it's a trade-off to have the
destination creation process same across different deployment methods.

This way we end up with a consistent creation of the destinations, both
at deployment and at runtime.

Destinationizer itself executes the creation in an asynchronous way
returning CountDownLatch to optionally wait for the task completion.

Additionally the TorqueBox::Messaging::Queue and
TorqueBox::Messaging::Topic documentation was rewritten to use the
proper yardoc tags.

The TorqueBox Project » torquebox #80 SUCCESS
This pull request looks good
(what's this?)

[TORQUE-1069] Make it possible to create queues and topic at runtime …
…in the way they are created currently at boot time

[TORQUE-1053] Use QueueInstaller to create queues using TorqueBox::Messaging::Queue.start method

This commit fixes both issues. The newly introduced Destinationizer
service is now responsible for creating destinations (queues and topic)
across TorqueBox. It does not talk directly to the HornetQ server and it
utilizes the QueueInstaller (or TopicInstaller) classes from polyglot.

The change itself results in a small overhead when creating the queues
(two MSC services are deployed) but it's a trade-off to have the
destination creation process same across different deployment methods.

This way we end up with a consistent creation of the destinations, both
at deployment and at runtime.

Destinationizer itself executes the creation in an asynchronous way
returning CountDownLatch to optionally wait for the task completion.

Additionally the TorqueBox::Messaging::Queue and
TorqueBox::Messaging::Topic documentation was rewritten to use the
proper yardoc tags.

bbrowning added a commit that referenced this pull request Apr 12, 2013

Merge pull request #152 from goldmann/TORQUE-1069-runtime-destination…
…izer

Fix for [TORQUE-1069] and [TORQUE-1053]

@bbrowning bbrowning merged commit 249702f into torquebox:master Apr 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment