New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db exceptions, query with binding #116

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
4 participants
@leroy0
Collaborator

leroy0 commented Jan 18, 2017

No description provided.

@leroy0 leroy0 assigned leroy0 and unassigned leroy0 Jan 18, 2017

@Exileum Exileum requested review from VasyOk and Exileum Jan 19, 2017

@Exileum Exileum self-assigned this Jan 19, 2017

@Exileum Exileum added the Enhancement label Jan 19, 2017

@Exileum Exileum added this to the Версия 2.2.0 milestone Jan 19, 2017

@Exileum

Прелестно. Функция дня - finally 🥇

Show outdated Hide outdated src/Db.php
class Exception extends PDOException
{
public function __construct(PDOException $exception)

This comment has been minimized.

@VasyOk

VasyOk Jan 19, 2017

Contributor
try {
    ...
} catch (PDOException $e) {
    throw new \TorrentPier\Db\Exception($e);
}

что-то тут не то.

@VasyOk

VasyOk Jan 19, 2017

Contributor
try {
    ...
} catch (PDOException $e) {
    throw new \TorrentPier\Db\Exception($e);
}

что-то тут не то.

This comment has been minimized.

@leroy0

leroy0 Jan 19, 2017

Collaborator

Что тут не то?

@leroy0

leroy0 Jan 19, 2017

Collaborator

Что тут не то?

This comment has been minimized.

@VasyOk

VasyOk Jan 20, 2017

Contributor

Конструктор ничего полезного в данном случае не делает. Изменять его не имеет смысла.

@VasyOk

VasyOk Jan 20, 2017

Contributor

Конструктор ничего полезного в данном случае не делает. Изменять его не имеет смысла.

This comment has been minimized.

@leroy0

leroy0 Jan 20, 2017

Collaborator

Так это, чтобы передать code и errorInfo. Как ты по другому ещё сделаешь? В твоей любимой доктрине так же сделано.

@leroy0

leroy0 Jan 20, 2017

Collaborator

Так это, чтобы передать code и errorInfo. Как ты по другому ещё сделаешь? В твоей любимой доктрине так же сделано.

@leroy0 leroy0 changed the title from Db exceptions to Db exceptions, query with binding Jan 20, 2017

@VasyOk

VasyOk approved these changes Jan 20, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 20, 2017

Current coverage is 38.19% (diff: 0.00%)

Merging #116 into develop will decrease coverage by 2.80%

@@            develop       #116   diff @@
==========================================
  Files            14         15     +1   
  Lines           300        322    +22   
  Methods          61         62     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            123        123          
- Misses          177        199    +22   
  Partials          0          0          

Powered by Codecov. Last update e829eaa...55f9afa

codecov-io commented Jan 20, 2017

Current coverage is 38.19% (diff: 0.00%)

Merging #116 into develop will decrease coverage by 2.80%

@@            develop       #116   diff @@
==========================================
  Files            14         15     +1   
  Lines           300        322    +22   
  Methods          61         62     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            123        123          
- Misses          177        199    +22   
  Partials          0          0          

Powered by Codecov. Last update e829eaa...55f9afa

@Exileum Exileum merged commit 83fa033 into torrentpier:develop Jan 20, 2017

5 of 7 checks passed

codecov/patch 0.00% of diff hit (target 41.00%)
Details
codecov/project 38.19% (-2.81%) compared to e829eaa
Details
Scrutinizer Analysis: 40 new issues, 6 updated code elements – Tests: passed
Details
SensioLabsInsight Code quality OK.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment