New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrent ajax file list fixes and small reformat #138

Merged
merged 1 commit into from Feb 5, 2017

Conversation

Projects
None yet
3 participants
@Exileum
Member

Exileum commented Feb 2, 2017

Исправления и небольшие оптимизации списка файлов в торренте. Попытка хоть как-то разделить логику и упростить класс. В версии 2.1.6 перенос в отдельное пространство классов нецелесообразен, в 2.2.0 сделать в приоритетном порядке.

@Exileum Exileum added this to the Версия 2.1.6 milestone Feb 2, 2017

@Exileum Exileum self-assigned this Feb 2, 2017

@Exileum Exileum requested review from VasyOk and leroy0 Feb 2, 2017

return "<div class=\"tor-root-dir\">{$this->root_dir}</div>$filelist";
} else {
return join('', $this->files_ary['/']);
}
}
public function build_filelist_array()
private function build_filelist_array()

This comment has been minimized.

return "<div class=\"tor-root-dir\">{$this->root_dir}</div>$filelist";
} else {
return join('', $this->files_ary['/']);
}
}
public function build_filelist_array()
private function build_filelist_array()
return "<div class=\"tor-root-dir\">{$this->root_dir}</div>$filelist";
} else {
return join('', $this->files_ary['/']);
}
}
public function build_filelist_array()
private function build_filelist_array()
@VasyOk

VasyOk approved these changes Feb 5, 2017

if (!$torrent) {
$this->ajax_die($lang['EMPTY_ATTACH_ID']);
$this->ajax_die($lang['ERROR_BUILD']);

This comment has been minimized.

@VasyOk

VasyOk Feb 5, 2017

Contributor

откуда этот появился? чей он будет?

$this
@VasyOk

VasyOk Feb 5, 2017

Contributor

откуда этот появился? чей он будет?

$this

This comment has been minimized.

@VasyOk

VasyOk Feb 5, 2017

Contributor

Нашел :(

@VasyOk

VasyOk Feb 5, 2017

Contributor

Нашел :(

@Exileum Exileum merged commit c4749b0 into torrentpier:master Feb 5, 2017

3 of 4 checks passed

ci/circleci No test commands were found
Details
SensioLabsInsight Code quality OK.
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details

@Exileum Exileum deleted the Exileum:hotfix/torrent_filelist_fixes branch Feb 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment