New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change paths to absolute pathname #143

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
2 participants
@VasyOk
Contributor

VasyOk commented Feb 5, 2017

No description provided.

@VasyOk VasyOk requested a review from Exileum Feb 5, 2017

Show outdated Hide outdated ajax.php
$DBS = new DBS($bb_cfg);
/**
* @param string $db_alias
* @return \sql_db

This comment has been minimized.

@Exileum

Exileum Feb 8, 2017

Member

Наверное стоит и тут пометить как @deprecated.

@Exileum

Exileum Feb 8, 2017

Member

Наверное стоит и тут пометить как @deprecated.

This comment has been minimized.

@VasyOk

VasyOk Feb 8, 2017

Contributor

добавил

@VasyOk

VasyOk Feb 8, 2017

Contributor

добавил

Show outdated Hide outdated library/config.php
@@ -115,21 +115,17 @@ public function use_template($template_file, $template_lang = '')
{
global $bb_cfg;
if (trim($template_file) == '') {
bb_die('No template file set');

This comment has been minimized.

@Exileum

Exileum Feb 8, 2017

Member

Проверка конечно не ахти, но все же. Точно не надо?

@Exileum

Exileum Feb 8, 2017

Member

Проверка конечно не ахти, но все же. Точно не надо?

This comment has been minimized.

@VasyOk

VasyOk Feb 8, 2017

Contributor

точно не нужно

@VasyOk

VasyOk Feb 8, 2017

Contributor

точно не нужно

@@ -35,7 +35,7 @@ function cron_get_file_lock()
$lock_obtained = false;
if (file_exists(CRON_ALLOWED)) {
# bb_log(date('H:i:s - ') . getmypid() .' -x-- FILE-LOCK try'. LOG_LF, CRON_LOG_DIR .'cron_check');
# bb_log(date('H:i:s - ') . getmypid() .' -x-- FILE-LOCK try'. LOG_LF, CRON_LOG_DIR .'/cron_check');

This comment has been minimized.

@Exileum

Exileum Feb 8, 2017

Member

Строку лучше вообще удалить.

@Exileum

Exileum Feb 8, 2017

Member

Строку лучше вообще удалить.

This comment has been minimized.

@VasyOk

VasyOk Feb 8, 2017

Contributor

на всякий случай, потом подчистим

@VasyOk

VasyOk Feb 8, 2017

Contributor

на всякий случай, потом подчистим

@@ -68,7 +68,7 @@ function cron_track_running($mode)
register_shutdown_function('cron_release_file_lock');
register_shutdown_function('cron_enable_board');
# bb_log(date('H:i:s - ') . getmypid() .' --x- FILE-LOCK OBTAINED ###############'. LOG_LF, CRON_LOG_DIR .'cron_check');
# bb_log(date('H:i:s - ') . getmypid() .' --x- FILE-LOCK OBTAINED ###############'. LOG_LF, CRON_LOG_DIR .'/cron_check');

This comment has been minimized.

@Exileum

Exileum Feb 8, 2017

Member

Эту строку тоже на удаление.

@Exileum

Exileum Feb 8, 2017

Member

Эту строку тоже на удаление.

@@ -1720,7 +1720,7 @@ function bb_simple_die($txt)
function bb_realpath($path)

This comment has been minimized.

@Exileum

Exileum Feb 8, 2017

Member

TODO @Exile37: заменить во всем проекта на обычную функцию, лишняя завязка на свои не нужна

@Exileum

Exileum Feb 8, 2017

Member

TODO @Exile37: заменить во всем проекта на обычную функцию, лишняя завязка на свои не нужна

@Exileum

Exileum approved these changes Feb 8, 2017

@Exileum Exileum merged commit ecd6ed7 into torrentpier:master Feb 8, 2017

3 of 4 checks passed

ci/circleci No test commands were found
Details
SensioLabsInsight Code quality OK.
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment