New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare php version. #226

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
2 participants
@VasyOk
Contributor

VasyOk commented Apr 25, 2017

Исправление ошибки сравнения версии php.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Apr 25, 2017

Codecov Report

Merging #226 into develop will decrease coverage by 10.6%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #226       +/-   ##
==============================================
- Coverage      35.65%   25.05%   -10.61%     
- Complexity       176      230       +54     
==============================================
  Files             16       26       +10     
  Lines            345      491      +146     
==============================================
  Hits             123      123               
- Misses           222      368      +146
Impacted Files Coverage Δ Complexity Δ
src/Config.php 36.76% <0%> (-63.24%) 36% <0%> (+13%)
src/Di.php 82.35% <0%> (-17.65%) 8% <0%> (ø)
src/Db.php 0% <0%> (ø) 83% <0%> (ø) ⬇️
src/ServiceProviders/VisitorServiceProvider.php 0% <0%> (ø) 1% <0%> (?)
src/ServiceProviders/LogServiceProvider.php 0% <0%> (ø) 5% <0%> (?)
src/ServiceProviders/CacheServiceProvider.php 0% <0%> (ø) 1% <0%> (?)
src/ServiceProviders/SettingsServiceProvider.php 0% <0%> (ø) 1% <0%> (?)
src/ServiceProviders/ConfigServiceProvider.php 0% <0%> (ø) 4% <0%> (?)
src/Cache/MemoryAdapter.php 0% <0%> (ø) 19% <0%> (?)
src/ServiceProviders/DbServiceProvider.php 0% <0%> (ø) 2% <0%> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1f623...ef57459. Read the comment docs.

codecov bot commented Apr 25, 2017

Codecov Report

Merging #226 into develop will decrease coverage by 10.6%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #226       +/-   ##
==============================================
- Coverage      35.65%   25.05%   -10.61%     
- Complexity       176      230       +54     
==============================================
  Files             16       26       +10     
  Lines            345      491      +146     
==============================================
  Hits             123      123               
- Misses           222      368      +146
Impacted Files Coverage Δ Complexity Δ
src/Config.php 36.76% <0%> (-63.24%) 36% <0%> (+13%)
src/Di.php 82.35% <0%> (-17.65%) 8% <0%> (ø)
src/Db.php 0% <0%> (ø) 83% <0%> (ø) ⬇️
src/ServiceProviders/VisitorServiceProvider.php 0% <0%> (ø) 1% <0%> (?)
src/ServiceProviders/LogServiceProvider.php 0% <0%> (ø) 5% <0%> (?)
src/ServiceProviders/CacheServiceProvider.php 0% <0%> (ø) 1% <0%> (?)
src/ServiceProviders/SettingsServiceProvider.php 0% <0%> (ø) 1% <0%> (?)
src/ServiceProviders/ConfigServiceProvider.php 0% <0%> (ø) 4% <0%> (?)
src/Cache/MemoryAdapter.php 0% <0%> (ø) 19% <0%> (?)
src/ServiceProviders/DbServiceProvider.php 0% <0%> (ø) 2% <0%> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1f623...ef57459. Read the comment docs.

@Exileum Exileum self-requested a review Apr 26, 2017

@Exileum Exileum self-assigned this Apr 26, 2017

@Exileum Exileum added the Bug label Apr 26, 2017

@Exileum Exileum added this to the Версия 2.2.0 milestone Apr 26, 2017

@Exileum Exileum merged commit 8a98517 into torrentpier:develop Apr 26, 2017

9 of 10 checks passed

codecov/project 25.3% (-10.35%) compared to ec1f623
Details
CodeFactor No issues found.
Details
Scrutinizer 17 new issues
Details
SensioLabsInsight Code quality OK.
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing ec1f623...ef57459
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment