New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static code analyzer cherry picked from #228 #229

Merged
merged 32 commits into from May 9, 2017

Conversation

Projects
None yet
2 participants
@VasyOk
Contributor

VasyOk commented May 7, 2017

Прогон статическим анализатором кода - исключительно автоматические правки и ряд дополнений.

Exileum and others added some commits May 4, 2017

Binary-unsafe 'fopen(...)' usage
(cherry picked from commit b9686af)
Unit of measure 'px' is redundant.
(cherry picked from commit ca6d622)
If-return-return could be simplified.
(cherry picked from commit bcf57cd)
One-time use variables.
(cherry picked from commit 95575e1)
Strings normalization.
(cherry picked from commit 72f9ddd)
Ternary operator could be simplified.
(cherry picked from commit 57f0cd7)
'unset(...)' calls could be merged.
(cherry picked from commit 8b3d5e7)
Alias functions usage.
(cherry picked from commit 4a79c08)
Deprecated constructor style.
(cherry picked from commit 38a722e)
__DIR__ constant can be used.
(cherry picked from commit 891ef41)
Elvis operator can be used.
(cherry picked from commit 6a3bf7c)
'null === ...' can be used.
(cherry picked from commit ec96f65)
Type casting can be used.
(cherry picked from commit b5065ae)
'array_push(...)' misused.
(cherry picked from commit 897445b)
'file(...)' misused.
(cherry picked from commit 9a96dc6)
'stristr(...)/stripos(...)/strripos(...)' could be replaced with 'str…
…str(...)/strpos()/strrpos()'.

(cherry picked from commit eba06c0)
Parameter could be declared as array.
(cherry picked from commit 07c6fd4)
Class property initialization flaws.
(cherry picked from commit cf5285f)
Callable name case mismatched in a call.
(cherry picked from commit 43f3e91)
Prefixed increment/decrement equivalent.
(cherry picked from commit a4965bf)
Short syntax for applied operation.
(cherry picked from commit a391e21)
Static methods invocation via '->'.
(cherry picked from commit da1e5a5)
Unnecessary semicolon.
(cherry picked from commit fe79d6c)
@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum

Exileum approved these changes May 9, 2017

@Exileum Exileum changed the title from Некоторые правки в коде + некоторые коммиты из #228 to Static code analyzer cherry picked from #228 May 9, 2017

@Exileum Exileum self-assigned this May 9, 2017

@Exileum Exileum added this to the Версия 2.1.6 milestone May 9, 2017

@Exileum Exileum merged commit 0aae80b into torrentpier:master May 9, 2017

3 of 4 checks passed

ci/circleci No test commands were found
Details
CodeFactor No issues found.
Details
SensioLabsInsight Code quality OK.
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment