New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-4 compatible legacy code autoloading #237

Merged
merged 2 commits into from May 23, 2017

Conversation

Projects
None yet
2 participants
@Exileum
Member

Exileum commented May 22, 2017

Переход на относительно-совместимую с PSR-4 автозагрузку (на данный момент за ненадобностью нет только вложенной папки соответствующей неймспейсу). Попутное исправление ряда обнаруженных при этом ошибок (например, совместное использование одного родительского класса кешем и датастор).

Переход на подобного рода загрузку позволил избавиться от излишних подключений файлов, а также упростил работу с кодом проекта, т.к. все классы, которые так или иначе можно расширить теперь расположены в одном месте.

@Exileum Exileum added this to the Версия 2.1.6 milestone May 22, 2017

@Exileum Exileum self-assigned this May 22, 2017

@Exileum Exileum requested a review from VasyOk May 22, 2017

public $filesize = 0;
public $filetime = 0;
public $thumbnail = 0;
public $page = 0; // On which page we are on ? This should be filled by child classes.
$attachment_id = 0;
$actual_element = 0;
for ($i = 0, $iMax = count($actual_id_list); $i < $iMax; $i++) {
public $filesize = 0;
public $filetime = 0;
public $thumbnail = 0;
public $page = 0; // On which page we are on ? This should be filled by child classes.
$error_msg .= $lang['ERROR_EMPTY_ADD_ATTACHBOX'];
}
$this->upload_attachment();
// Descide the Upload method
$ini_val = 'ini_get';
if (@$ini_val('open_basedir')) {

This comment has been minimized.

@@ -319,7 +320,7 @@ public function sql_fetchrowset($result, $field_name = '')
$rowset = [];
while ($row = mysqli_fetch_assoc($result)) {
$rowset[] = ($field_name) ? $row[$field_name] : $row;
$rowset[] = $field_name ? $row[$field_name] : $row;
}
return $rowset;
@@ -319,7 +320,7 @@ public function sql_fetchrowset($result, $field_name = '')
$rowset = [];
while ($row = mysqli_fetch_assoc($result)) {
$rowset[] = ($field_name) ? $row[$field_name] : $row;
$rowset[] = $field_name ? $row[$field_name] : $row;
}
return $rowset;
@@ -319,7 +320,7 @@ public function sql_fetchrowset($result, $field_name = '')
$rowset = [];
while ($row = mysqli_fetch_assoc($result)) {
$rowset[] = ($field_name) ? $row[$field_name] : $row;
$rowset[] = $field_name ? $row[$field_name] : $row;
}
return $rowset;
@@ -319,7 +320,7 @@ public function sql_fetchrowset($result, $field_name = '')
$rowset = [];
while ($row = mysqli_fetch_assoc($result)) {
$rowset[] = ($field_name) ? $row[$field_name] : $row;
$rowset[] = $field_name ? $row[$field_name] : $row;
}
return $rowset;

Exileum added some commits May 22, 2017

@Exileum Exileum merged commit 8104657 into torrentpier:master May 23, 2017

3 of 5 checks passed

SensioLabsInsight Analyzing the code.
Details
ci/circleci CircleCI is running your tests
Details
codebeat no reportable quality changes
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
hound No violations found. Woof!

@Exileum Exileum deleted the Exileum:feature/legacy_autoloading branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment