Skip to content

Commit

Permalink
Fix failure to resume from initrds
Browse files Browse the repository at this point in the history
Commit 8314418 (Freezer: make kernel
threads nonfreezable by default) breaks freezing when attempting to resume
from an initrd, because the init (which is freezeable) spins while waiting
for another thread to run /linuxrc, but doesn't check whether it has been
told to enter the refrigerator.  The original patch replaced a call to
try_to_freeze() with a call to yield().  I believe a simple reversion is
wrong because if !CONFIG_PM_SLEEP, try_to_freeze() is a noop.  It should
still yield.

Signed-off-by: Nigel Cunningham <nigel@nigel.suspend2.net>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Nigel Cunningham authored and Linus Torvalds committed Sep 19, 2007
1 parent 2c392a4 commit 019ad4a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion init/do_mounts_initrd.c
Expand Up @@ -57,8 +57,10 @@ static void __init handle_initrd(void)

pid = kernel_thread(do_linuxrc, "/linuxrc", SIGCHLD);
if (pid > 0)
while (pid != sys_wait4(-1, NULL, 0, NULL))
while (pid != sys_wait4(-1, NULL, 0, NULL)) {
try_to_freeze();
yield();
}

/* move initrd to rootfs' /old */
sys_fchdir(old_fd);
Expand Down

0 comments on commit 019ad4a

Please sign in to comment.