Skip to content

Commit 04c9b00

Browse files
HBh25Ymarckleinebudde
authored andcommitted
can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path
There is no need to call dev_kfree_skb() when usb_submit_urb() fails because can_put_echo_skb() deletes original skb and can_free_echo_skb() deletes the cloned skb. Fixes: 51f3baa ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent 3d3925f commit 04c9b00

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: drivers/net/can/usb/mcba_usb.c

-1
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,6 @@ static netdev_tx_t mcba_usb_start_xmit(struct sk_buff *skb,
364364
xmit_failed:
365365
can_free_echo_skb(priv->netdev, ctx->ndx, NULL);
366366
mcba_usb_free_ctx(ctx);
367-
dev_kfree_skb(skb);
368367
stats->tx_dropped++;
369368

370369
return NETDEV_TX_OK;

0 commit comments

Comments
 (0)