Permalink
Browse files

platform: goldfish: pipe: use get_user_pages_unlocked()

Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.

Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information...
lorenzo-stoakes authored and gregkh committed Nov 1, 2016
1 parent 9d59c6e commit 052662cada1f2104dedfab68866e403a508e045c
Showing with 2 additions and 4 deletions.
  1. +2 −4 drivers/platform/goldfish/goldfish_pipe.c
@@ -308,10 +308,8 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
* returns a small amount, then there's no need to pin that
* much memory to the process.
*/
down_read(&current->mm->mmap_sem);
ret = get_user_pages(address, 1, is_write ? 0 : FOLL_WRITE,
&page, NULL);
up_read(&current->mm->mmap_sem);
ret = get_user_pages_unlocked(address, 1, &page,
is_write ? 0 : FOLL_WRITE);
if (ret < 0)
break;

0 comments on commit 052662c

Please sign in to comment.