Skip to content

Commit 07d86ca

Browse files
xairytiwai
authored andcommitted
ALSA: usb-audio: avoid freeing umidi object twice
The 'umidi' object will be free'd on the error path by snd_usbmidi_free() when tearing down the rawmidi interface. So we shouldn't try to free it in snd_usbmidi_create() after having registered the rawmidi interface. Found by KASAN. Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com> Acked-by: Clemens Ladisch <clemens@ladisch.de> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 86c2ee1 commit 07d86ca

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: sound/usb/midi.c

-1
Original file line numberDiff line numberDiff line change
@@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
24552455
else
24562456
err = snd_usbmidi_create_endpoints(umidi, endpoints);
24572457
if (err < 0) {
2458-
snd_usbmidi_free(umidi);
24592458
return err;
24602459
}
24612460

0 commit comments

Comments
 (0)