Permalink
Browse files

fs/cifs/cifs_dfs_ref.c: fix potential memory leakage

When it goes to error through line 144, the memory allocated to *devname is
not freed, and the caller doesn't free it either in line 250. So we free the
memroy of *devname in function cifs_compose_mount_options() when it goes to
error.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
CC: stable <stable@kernel.org>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
  • Loading branch information...
1 parent e3e2775 commit 10b8c7dff5d3633b69e77f57d404dab54ead3787 @ccding ccding committed with smfrench Jan 23, 2013
Showing with 2 additions and 0 deletions.
  1. +2 −0 fs/cifs/cifs_dfs_ref.c
View
@@ -226,6 +226,8 @@ char *cifs_compose_mount_options(const char *sb_mountdata,
compose_mount_options_err:
kfree(mountdata);
mountdata = ERR_PTR(rc);
+ kfree(*devname);
+ *devname = NULL;
goto compose_mount_options_out;
}

0 comments on commit 10b8c7d

Please sign in to comment.