Skip to content
Browse files

xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to E…


Benjamin Moody reported to Debian that XFS partially wedges when a chgrp
fails on account of being out of disk quota.  I ran his reproducer

# adduser dummy
# adduser dummy plugdev

# dd if=/dev/zero bs=1M count=100 of=test.img
# mkfs.xfs test.img
# mount -t xfs -o gquota test.img /mnt
# mkdir -p /mnt/dummy
# chown -c dummy /mnt/dummy
# xfs_quota -xc 'limit -g bsoft=100k bhard=100k plugdev' /mnt

(and then as user dummy)

$ dd if=/dev/urandom bs=1M count=50 of=/mnt/dummy/foo
$ chgrp plugdev /mnt/dummy/foo

and saw:

WARNING: lock held when returning to user space!
5.3.0-rc5 #rc5 Tainted: G        W
chgrp/47006 is leaving the kernel with locks still held!
1 lock held by chgrp/47006:
 #0: 000000006664ea2d (&xfs_nondir_ilock_class){++++}, at: xfs_ilock+0xd2/0x290 [xfs]

...which is clearly caused by xfs_setattr_nonsize failing to unlock the
ILOCK after the xfs_qm_vop_chown_reserve call fails.  Add the missing

Fixes: 253f491 ("xfs: better xfs_trans_alloc interface")
Signed-off-by: Darrick J. Wong <>
Reviewed-by: Dave Chinner <>
Tested-by: Salvatore Bonaccorso <>
  • Loading branch information...
djwong committed Aug 23, 2019
1 parent b682716 commit 1fb254aa983bf190cfd685d40c64a480a9bafaee
Showing with 1 addition and 0 deletions.
  1. +1 −0 fs/xfs/xfs_iops.c
@@ -793,6 +793,7 @@ xfs_setattr_nonsize(

xfs_iunlock(ip, XFS_ILOCK_EXCL);

0 comments on commit 1fb254a

Please sign in to comment.
You can’t perform that action at this time.