Skip to content
Browse files

mm: __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq

To use spin_{un}lock_irq is dangerous if caller disabled interrupt.
During aio buffer migration, we have a possibility to see the following
call stack.

aio_migratepage  [disable interrupt]

This mean, current aio migration is a deadlockable.  spin_lock_irqsave
is a safer alternative and we should use it.

Signed-off-by: KOSAKI Motohiro <>
Reported-by: David Rientjes>
Cc: <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
  • Loading branch information...
1 parent 7bc35fd commit 227d53b397a32a7614667b3ecaf1d89902fb6c12 @kosaki kosaki committed with Feb 6, 2014
Showing with 4 additions and 2 deletions.
  1. +4 −2 fs/buffer.c
6 fs/buffer.c
@@ -654,14 +654,16 @@ EXPORT_SYMBOL(mark_buffer_dirty_inode);
static void __set_page_dirty(struct page *page,
struct address_space *mapping, int warn)
- spin_lock_irq(&mapping->tree_lock);
+ unsigned long flags;
+ spin_lock_irqsave(&mapping->tree_lock, flags);
if (page->mapping) { /* Race with truncate? */
WARN_ON_ONCE(warn && !PageUptodate(page));
account_page_dirtied(page, mapping);
page_index(page), PAGECACHE_TAG_DIRTY);
- spin_unlock_irq(&mapping->tree_lock);
+ spin_unlock_irqrestore(&mapping->tree_lock, flags);
__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);

0 comments on commit 227d53b

Please sign in to comment.
Something went wrong with that request. Please try again.