Skip to content

Commit 297a696

Browse files
Wei Yongjundavem330
Wei Yongjun
authored andcommitted
net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()
platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference a bit later in the code. This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = platform_get_resource(pdev, t, n); + if (!res) + return -EINVAL; ... when != res == NULL e = devm_ioremap(e1, res->start, e2); Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ecb1028 commit 297a696

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: drivers/net/phy/mdio-bcm-unimac.c

+2
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,8 @@ static int unimac_mdio_probe(struct platform_device *pdev)
205205
return -ENOMEM;
206206

207207
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
208+
if (!r)
209+
return -EINVAL;
208210

209211
/* Just ioremap, as this MDIO block is usually integrated into an
210212
* Ethernet MAC controller register range

0 commit comments

Comments
 (0)