Skip to content

Commit 2b13d06

Browse files
Salva Peiródavem330
Salva Peiró
authored andcommitted
wanxl: fix info leak in ioctl
The wanxl_ioctl() code fails to initialize the two padding bytes of struct sync_serial_settings after the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Salva Peiró <speiro@ai2.upv.es> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b8bde1c commit 2b13d06

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: drivers/net/wan/wanxl.c

+1
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
355355
ifr->ifr_settings.size = size; /* data size wanted */
356356
return -ENOBUFS;
357357
}
358+
memset(&line, 0, sizeof(line));
358359
line.clock_type = get_status(port)->clocking;
359360
line.clock_rate = 0;
360361
line.loopback = 0;

0 commit comments

Comments
 (0)