Skip to content

Commit 2d6fbfe

Browse files
miniplidavem330
authored andcommitted
caif: Fix missing msg_namelen update in caif_seqpkt_recvmsg()
The current code does not fill the msg_name member in case it is set. It also does not set the msg_namelen member to 0 and therefore makes net/socket.c leak the local, uninitialized sockaddr_storage variable to userland -- 128 bytes of kernel stack memory. Fix that by simply setting msg_namelen to 0 as obviously nobody cared about caif_seqpkt_recvmsg() not filling the msg_name in case it was set. Cc: Sjur Braendeland <sjur.brandeland@stericsson.com> Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c8c4991 commit 2d6fbfe

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: net/caif/caif_socket.c

+2
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,8 @@ static int caif_seqpkt_recvmsg(struct kiocb *iocb, struct socket *sock,
286286
if (m->msg_flags&MSG_OOB)
287287
goto read_error;
288288

289+
m->msg_namelen = 0;
290+
289291
skb = skb_recv_datagram(sk, flags, 0 , &ret);
290292
if (!skb)
291293
goto read_error;

0 commit comments

Comments
 (0)