Browse files

caif: Fix missing msg_namelen update in caif_seqpkt_recvmsg()

The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about caif_seqpkt_recvmsg() not filling the msg_name in case it was

Cc: Sjur Braendeland <>
Signed-off-by: Mathias Krause <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent c8c4991 commit 2d6fbfe733f35c6b355c216644e08e149c61b271 @minipli minipli committed with davem330 Apr 7, 2013
Showing with 2 additions and 0 deletions.
  1. +2 −0 net/caif/caif_socket.c
@@ -286,6 +286,8 @@ static int caif_seqpkt_recvmsg(struct kiocb *iocb, struct socket *sock,
if (m->msg_flags&MSG_OOB)
goto read_error;
+ m->msg_namelen = 0;
skb = skb_recv_datagram(sk, flags, 0 , &ret);
if (!skb)
goto read_error;

0 comments on commit 2d6fbfe

Please sign in to comment.