Skip to content

Commit 3057241

Browse files
committed
USB: serial: omninet: fix reference leaks at open
This driver needlessly took another reference to the tty on open, a reference which was then never released on close. This lead to not just a leak of the tty, but also a driver reference leak that prevented the driver from being unloaded after a port had once been opened. Fixes: 4a90f09 ("tty: usb-serial krefs") Cc: stable <stable@vger.kernel.org> # 2.6.28 Signed-off-by: Johan Hovold <johan@kernel.org>
1 parent 0b1d250 commit 3057241

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

Diff for: drivers/usb/serial/omninet.c

-6
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port)
142142

143143
static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port)
144144
{
145-
struct usb_serial *serial = port->serial;
146-
struct usb_serial_port *wport;
147-
148-
wport = serial->port[1];
149-
tty_port_tty_set(&wport->port, tty);
150-
151145
return usb_serial_generic_open(tty, port);
152146
}
153147

0 commit comments

Comments
 (0)