Skip to content

Commit

Permalink
USB: serial: omninet: fix reference leaks at open
Browse files Browse the repository at this point in the history
This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.

Fixes: 4a90f09 ("tty: usb-serial krefs")
Cc: stable <stable@vger.kernel.org>	# 2.6.28
Signed-off-by: Johan Hovold <johan@kernel.org>
  • Loading branch information
jhovold committed Mar 8, 2017
1 parent 0b1d250 commit 3057241
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/usb/serial/omninet.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port)

static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port)
{
struct usb_serial *serial = port->serial;
struct usb_serial_port *wport;

wport = serial->port[1];
tty_port_tty_set(&wport->port, tty);

return usb_serial_generic_open(tty, port);
}

Expand Down

0 comments on commit 3057241

Please sign in to comment.