Skip to content

Commit 3c0c5cf

Browse files
miniplidavem330
authored andcommitted
atm: fix info leak via getsockname()
The ATM code fails to initialize the two padding bytes of struct sockaddr_atmpvc inserted for alignment. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent e862f1a commit 3c0c5cf

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: net/atm/pvc.c

+1
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ static int pvc_getname(struct socket *sock, struct sockaddr *sockaddr,
9595
return -ENOTCONN;
9696
*sockaddr_len = sizeof(struct sockaddr_atmpvc);
9797
addr = (struct sockaddr_atmpvc *)sockaddr;
98+
memset(addr, 0, sizeof(*addr));
9899
addr->sap_family = AF_ATMPVC;
99100
addr->sap_addr.itf = vcc->dev->number;
100101
addr->sap_addr.vpi = vcc->vpi;

0 commit comments

Comments
 (0)