Browse files

romfs: fix returm err while getting inode in fill_super

Getting an inode by romfs_iget may lead to an err in fill_super, and the
err value should be return.

And it should return -ENOMEM instead while d_make_root fails, fix it too.

Signed-off-by: Rui Xiang <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
  • Loading branch information...
1 parent 3089a4c commit 40e2c71d57565a82970a5a2b75f7eb67bb3252f4 Rui Xiang committed with Jan 23, 2014
Showing with 2 additions and 4 deletions.
  1. +2 −4 fs/romfs/super.c
@@ -533,16 +533,14 @@ static int romfs_fill_super(struct super_block *sb, void *data, int silent)
root = romfs_iget(sb, pos);
if (IS_ERR(root))
- goto error;
+ return PTR_ERR(root);
sb->s_root = d_make_root(root);
if (!sb->s_root)
- goto error;
+ return -ENOMEM;
return 0;
- return -EINVAL;
ret = -EINVAL;

0 comments on commit 40e2c71

Please sign in to comment.