Skip to content

Commit 45c1380

Browse files
Navidembroonie
authored andcommitted
ASoC: SOF: ipc: Fix memory leak in sof_set_get_large_ctrl_data
In the implementation of sof_set_get_large_ctrl_data() there is a memory leak in case an error. Release partdata if sof_get_ctrl_copy_params() fails. Fixes: 54d198d ("ASoC: SOF: Propagate sof_get_ctrl_copy_params() error properly") Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Link: https://lore.kernel.org/r/20191027215330.12729-1-navid.emamdoost@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c0a333d commit 45c1380

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Diff for: sound/soc/sof/ipc.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -572,8 +572,10 @@ static int sof_set_get_large_ctrl_data(struct snd_sof_dev *sdev,
572572
else
573573
err = sof_get_ctrl_copy_params(cdata->type, partdata, cdata,
574574
sparams);
575-
if (err < 0)
575+
if (err < 0) {
576+
kfree(partdata);
576577
return err;
578+
}
577579

578580
msg_bytes = sparams->msg_bytes;
579581
pl_size = sparams->pl_size;

0 commit comments

Comments
 (0)