Browse files

rose: fix info leak via msg_name in rose_recvmsg()

The code in rose_recvmsg() does not initialize all of the members of
struct sockaddr_rose/full_sockaddr_rose when filling the sockaddr info.
Nor does it initialize the padding bytes of the structure inserted by
the compiler for alignment. This will lead to leaking uninitialized
kernel stack bytes in net/socket.c.

Fix the issue by initializing the memory used for sockaddr info with

Cc: Ralf Baechle <>
Signed-off-by: Mathias Krause <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent d26d650 commit 4a184233f21645cf0b719366210ed445d1024d72 @minipli minipli committed with davem330 Apr 7, 2013
Showing with 1 addition and 0 deletions.
  1. +1 −0 net/rose/af_rose.c
@@ -1253,6 +1253,7 @@ static int rose_recvmsg(struct kiocb *iocb, struct socket *sock,
skb_copy_datagram_iovec(skb, 0, msg->msg_iov, copied);
if (srose != NULL) {
+ memset(srose, 0, msg->msg_namelen);
srose->srose_family = AF_ROSE;
srose->srose_addr = rose->dest_addr;
srose->srose_call = rose->dest_call;

0 comments on commit 4a18423

Please sign in to comment.