Please sign in to comment.
RDS: fix rds-ping spinlock recursion
This is the revised patch for fixing rds-ping spinlock recursion according to Venkat's suggestions. RDS ping/pong over TCP feature has been broken for years(2.6.39 to 3.6.0) since we have to set TCP cork and call kernel_sendmsg() between ping/pong which both need to lock "struct sock *sk". However, this lock has already been hold before rds_tcp_data_ready() callback is triggerred. As a result, we always facing spinlock resursion which would resulting in system panic. Given that RDS ping is only used to test the connectivity and not for serious performance measurements, we can queue the pong transmit to rds_wq as a delayed response. Reported-by: Dan Carpenter <email@example.com> CC: Venkat Venkatsubra <firstname.lastname@example.org> CC: David S. Miller <email@example.com> CC: James Morris <firstname.lastname@example.org> Signed-off-by: Jie Liu <email@example.com> Signed-off-by: David S. Miller <firstname.lastname@example.org>
- Loading branch information...