Skip to content
Browse files

Btrfs: fix enospc problems when deleting a subvol

Subvol delete is a special kind of awful where we use the global reserve to
cover the ENOSPC requirements.  The problem is once we're done removing
everything we do a btrfs_update_inode(), which by default will try to do the
delayed update stuff which will use it's own reserve.  There will be no
space in this reserve and we'll return ENOSPC.  So instead use
btrfs_update_inode_fallback() which will just fallback to updating the inode
item in the case of enospc.  This is fine because the global reserve covers
the space requirements for this.  With this patch I can now delete a subvol
on a problem image Dave Sterba sent me.  Thanks,

Reported-by: David Sterba <>
Signed-off-by: Josef Bacik <>
Signed-off-by: Chris Mason <>
  • Loading branch information...
1 parent c0f62de commit 5a24e84c55f57cc49bd1cab531b6ef28b6b7bdaa Josef Bacik committed with chrismason-xx Aug 8, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 fs/btrfs/inode.c
2 fs/btrfs/inode.c
@@ -3171,7 +3171,7 @@ int btrfs_unlink_subvol(struct btrfs_trans_handle *trans,
btrfs_i_size_write(dir, dir->i_size - name_len * 2);
dir->i_mtime = dir->i_ctime = CURRENT_TIME;
- ret = btrfs_update_inode(trans, root, dir);
+ ret = btrfs_update_inode_fallback(trans, root, dir);
if (ret)
btrfs_abort_transaction(trans, root, ret);

0 comments on commit 5a24e84

Please sign in to comment.
Something went wrong with that request. Please try again.