Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

kdump: append newline to the last lien of vmcoreinfo note

The last line of vmcoreinfo note does not end with \n.  Parsing all the
lines in note becomes easier if all lines end with \n instead of trying to
special case the last line.

I know at least one tool, vmcore-dmesg in kexec-tools tree which made the
assumption that all lines end with \n.  I think it is a good idea to fix

Signed-off-by: Vivek Goyal <>
Cc: "Eric W. Biederman" <>
Cc: Atsushi Kumagai <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
  • Loading branch information...
commit 63dca8d5b5ef7effb58b8d6892a024125c0fab0b 1 parent f19b9f7
@rhvgoyal rhvgoyal authored committed
Showing with 1 addition and 1 deletion.
  1. +1 −1  kernel/kexec.c
2  kernel/kexec.c
@@ -1424,7 +1424,7 @@ static void update_vmcoreinfo_note(void)
void crash_save_vmcoreinfo(void)
- vmcoreinfo_append_str("CRASHTIME=%ld", get_seconds());
+ vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds());
Please sign in to comment.
Something went wrong with that request. Please try again.