Skip to content

Commit 654b404

Browse files
committed
USB: serial: io_ti: fix information leak in completion handler
Add missing sanity check to the bulk-in completion handler to avoid an integer underflow that can be triggered by a malicious device. This avoids leaking 128 kB of memory content from after the URB transfer buffer to user space. Fixes: 8c209e6 ("USB: make actual_length in struct urb field u32") Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable <stable@vger.kernel.org> # 2.6.30 Signed-off-by: Johan Hovold <johan@kernel.org>
1 parent 367ec17 commit 654b404

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: drivers/usb/serial/io_ti.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1761,7 +1761,7 @@ static void edge_bulk_in_callback(struct urb *urb)
17611761

17621762
port_number = edge_port->port->port_number;
17631763

1764-
if (edge_port->lsr_event) {
1764+
if (urb->actual_length > 0 && edge_port->lsr_event) {
17651765
edge_port->lsr_event = 0;
17661766
dev_dbg(dev, "%s ===== Port %u LSR Status = %02x, Data = %02x ======\n",
17671767
__func__, port_number, edge_port->lsr_mask, *data);

0 commit comments

Comments
 (0)