Browse files

HID: i2c-hid: Limit reads to wMaxInputLength bytes for input events

d1c7e29 (HID: i2c-hid: prevent buffer overflow in early IRQ)
changed hid_get_input() to read ihid->bufsize bytes, which can be
more than wMaxInputLength. This is the case with the Dell XPS 13
9343, and it is causing events to be missed. In some cases the
missed events are releases, which can cause the cursor to jump or
freeze, among other problems. Limit the number of bytes read to
min(wMaxInputLength, ihid->bufsize) to prevent such problems.

Fixes: d1c7e29 "HID: i2c-hid: prevent buffer overflow in early IRQ"
Signed-off-by: Seth Forshee <>
Reviewed-by: Benjamin Tissoires <>
Signed-off-by: Jiri Kosina <>
  • Loading branch information...
Seth Forshee Jiri Kosina
Seth Forshee authored and Jiri Kosina committed Feb 20, 2015
1 parent b94993f commit 6d00f37e49d95e640a3937a4a1ae07dbe92a10cb
Showing with 4 additions and 1 deletion.
  1. +4 −1 drivers/hid/i2c-hid/i2c-hid.c
@@ -370,7 +370,10 @@ static int i2c_hid_hwreset(struct i2c_client *client)
static void i2c_hid_get_input(struct i2c_hid *ihid)
int ret, ret_size;
int size = ihid->bufsize;
int size = le16_to_cpu(ihid->hdesc.wMaxInputLength);
if (size > ihid->bufsize)
size = ihid->bufsize;
ret = i2c_master_recv(ihid->client, ihid->inbuf, size);
if (ret != size) {

0 comments on commit 6d00f37

Please sign in to comment.